OCTO-11510 #391
Merged
Merged
Conversation
…ckage (constants, parser, reader, writer). Emit VTT as class attribute instead of leaking into inline CSS, add text-align from Layout alignment, produce valid stylesheet rules for VTT class styles, filter non-CSS keys, silently drop writing direction. Fix rules-dict mutation in _recreate_style_block, inline dead hooks, add docstrings.
panasicov
approved these changes
Jul 22, 2026
lorandvarga
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
classeslist emitted asclass=attribute (not leaked into inline CSS),text-alignderived from Layout alignment, VTT class styles produce valid CSS rules in stylesheet (.yellow { color: yellow; }), writing direction silently dropped (SAMI has no writing-mode).pycaption/sami.py(809 lines) intopycaption/sami/package: constants.py, parser.py, reader.py, writer.py with unchanged public API._recreate_style_blockmutating caller's rules dict, filterwebvtt_positioning/writing_directionfrom inline style output, inline dead extension-point hooks in reader, remove dead_encodemethod, add docstrings.Test plan